Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP : Use Docker #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP : Use Docker #53

wants to merge 1 commit into from

Conversation

MattMattV
Copy link

Hello !

I added a Dockerfile to run the application without to have to setup a webserver.
I noticed some hot spots :

  • the last login function is not working (even when mounting host /var/log/lastlog)
  • ping feature does not work as-is (the last line in output does not contains rtt anymore but round-trip)

Also to get the port scan function to work, user need to tells docker to bind the ports inside the container.

I also need some feedback also to document how to run the image, will you upload the image to the Docker Hub ? (I can help you to set up simple CI) Or the user should build itself ?

Personally, I think th efirst option is better but it's up to you (:

@huguesgr
Copy link
Contributor

What is the point of running this into a Docker container - you will obtain data (CPU usage, etc.) that is inside the container, and not on the host system, right?

@MattMattV
Copy link
Author

MattMattV commented Oct 24, 2017

The major pro is taht users just have one command to write to launch the container ! It's a bit easier than having to setup a whole webserver ! And no, stats from CPU, RAM and disks are from host (:

@Admin9705
Copy link

Admin9705 commented Jun 13, 2018

I run a site called https://plexguide.com and it make it easy for the app to deployed in one click. It doesn't run in dependency hell and is easy to manage. For example, we use netdata and that's what we'll continue to offer due to it's ease in installing. Containers also prevent conflicts with the system. Just tagging along with @MattMattV Netdata has the ability to reach outside the container and pull all this info.

https://github.com/Admin9705/PlexGuide.com-The-Awesome-Plex-Server/blob/Version-5/ansible/roles/netdata/tasks/main.yml

Example of their execution

image

@justinglock40
Copy link

The major pro is taht users just have one command to write to launch the container ! It's a bit easier than having to setup a whole webserver ! And no, stats from CPU, RAM and disks are from host (:

Did the docker container ever get built?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants