Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying qemu-cgc patch directly to qemu #5

Open
wants to merge 54 commits into
base: master
Choose a base branch
from

Conversation

g0kkk
Copy link

@g0kkk g0kkk commented Oct 17, 2018

Removed the patches that were applied by cloning qemu-cgc from Mechaphish. Instead, a new patch file, version.patch is being applied to the qemu version that is being cloned while building shellphish-qemu.

@rhelmot
Copy link
Member

rhelmot commented Oct 17, 2018

It seems that 90% of version.patch is just removing files, which makes it unreasonably huge. Can you refactor this so those removals are done explicitly in the setup script, or maybe a removals.sh in the patches dir?

@g0kkk
Copy link
Author

g0kkk commented Oct 18, 2018

Reworked on the same and that should do it.

  • Doesn't use a script to remove the unnecessary files though. Instead, the version.patch have been modified accordingly preserving the original conditions.

@rhelmot
Copy link
Member

rhelmot commented Oct 18, 2018

version.patch is still a million lines long, probably because it includes the addition of the entire dtc repo. do we actually need that?

@g0kkk
Copy link
Author

g0kkk commented Oct 19, 2018

I did not notice the dtc repo and it ain't required. I'll remove that

@g0kkk
Copy link
Author

g0kkk commented Oct 19, 2018

Removed the unnecessary additions

@rhelmot
Copy link
Member

rhelmot commented Oct 19, 2018

Now it includes all of pixman, which is 70% of the diff, can that go away?

@g0kkk
Copy link
Author

g0kkk commented Oct 19, 2018

When that was ignored, make failed which is why that is still there.

@rhelmot
Copy link
Member

rhelmot commented Oct 19, 2018

That seems extremely bad - we don't need a graphics library for emulating CGC binaries. Can you investigate why this is the case?

@g0kkk
Copy link
Author

g0kkk commented Oct 19, 2018

Well, I was wrong on that part. It does work without pixman, removed it and would be pushing the same soon.

There were some other issues which actually lead to the above-mentioned pixman issues about which I came to know right now as I investigated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants