Remove unused DekuWrite trait #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for 53caf58Click to view benchmark
|
wcampbell0x2a
force-pushed
the
impl-writer-inline-read-bytes
branch
from
dbb3849
to
303edc7
Compare
|
@wcampbell0x2a no longer sure of the status on this one |
wcampbell0x2a
force-pushed
the
impl-writer-inline-read-bytes
branch
from
6c78f99
to
176383a
Compare
wcampbell0x2a
force-pushed
the
remove-unused-deku-write
branch
from
6e7f99a
to
e07810a
Compare
Now it's updated |
Benchmark for 2867195Click to view benchmark
|
|
@wcampbell0x2a could you update the PR description? Why are these unused? |
sharksforarms
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are now unused, because internally we just now use DekuWriter