Add support for specifying the ID's endianness #337
+83
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcampbell0x2a
requested changes
May 24, 2023
You've peaked my interest, is this a public data-format? Sounds funky. |
InusualZ
reviewed
May 28, 2023
deku-derive/src/lib.rs
Outdated
| @@ -203,6 +207,8 @@ impl DekuData { | |||
| Err(cerror(data.id_type.span(), "`type` only supported on enum")) | |||
| } else if data.id.is_some() { | |||
| Err(cerror(data.id.span(), "`id` only supported on enum")) | |||
| } else if data.id_endian.is_some() { | |||
| Err(cerror(data.id.span(), "`endian_id` only supported on enum")) | |||
There was a problem hiding this comment.
I think the error message should say id_endian?
|
I've not stared at Miri output much before, but the failures I examined do not appear to be related to the changes I made. |
Yah, we really should disable those, or just disable the ones we know fail? Miri doesn't really like bitvec, and I don't think those issues will be fixed anytime soon. |
wcampbell0x2a
previously approved these changes
May 30, 2023
Doesn't propagate any further down the dependency tree, *only* affects ID parsing.
wcampbell0x2a
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've got a need to specify the endianness of a discriminator, without having that propagate to substructures. Hence this little change.
Great crate, BTW; well-documented and easy to use!