-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/137 add entry point index js #138
base: master
Are you sure you want to change the base?
Issue/137 add entry point index js #138
Conversation
Also by the way the ...
"module": "./src/index.js",
"browser": "./src/index.js",
... However, if doing so I'm not too sure about how this would be backward-compatible with previous versions. import {
Chessboard,
BORDER_TYPE,
FEN
} from 'shaack/cm-chessboard' |
I understand that this is your style of doing imports, but I prefer importing from the original files. Maybe because I am from Java and want to keep it simple. For importing the classes from <script type="importmap">
{
"imports": {
"cm-chessboard/": "./node_modules/cm-chessboard/"
}
}
</script> With defining the module path in import {Chessboard, COLOR, INPUT_EVENT_TYPE} from "cm-chessboard/src/Chessboard.js" What is the reason that you want to put everything in an index.js? This file must also be maintained for changes such as refactoring. |
See #137 (comment) |
All examples have been tested using the new entry point and now some are importing
cm-chessboard
files fromindex.js
. Closes #137