mach: Upgrade boto3 and remove Python < 3.10 dependencies #32208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change upgrades boto3, which will fix an upcoming urllib3 version conflict in the WPT and also removes all remaining dependencies for Python version < 3.10. The requirement for Servo is 3.10 now. Fixes servo#32201.
sagudev
approved these changes
May 1, 2024
There was a problem hiding this comment.
According to https://github.com/servo/servo/tree/main?tab=readme-ov-file#macos we already required python 3.10 (but I guess we actually supported more).
You're totally correct. We required at least Python 3.10, but the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change upgrades boto3, which will fix an upcoming urllib3 version
conflict in the WPT and also removes all remaining dependencies for
Python version < 3.10. The requirement for Servo is 3.10 now.
Fixes #32201.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors