feat(Mocha): Patch circular references parallel invocation bug #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medikoo
force-pushed
the
0113-patch-mocha-parallel-bug
branch
2 times, most recently
from
132453a
to
33551a1
Compare
medikoo
force-pushed
the
0113-patch-mocha-parallel-bug
branch
from
33551a1
to
1b70ebf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for mochajs/mocha#4552
This patch ensures that eventual circular references in array won't crash Mocha in parallel mode. It won't prevent hang in case error cross-references to its own instance, but I take we don't have to worry about this scenario at this point.
Confirmed to have no effect when no parallel processing is applied