Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows symlink creation #109

Closed
wants to merge 2 commits into from

Conversation

LadnovSasha
Copy link

@LadnovSasha LadnovSasha commented Aug 14, 2018

Should fix #23, #89 , #100

According to the docs on windows we should define symlink type

Due to inactivity I am closing this PR because it goes from master (i am planning to publish it), instead I've created the same pull request in #109

Fork with fixes published here: https://github.com/LadnovSasha/serverless-plugin-typescript

Copy link

@ThomasVuillaume ThomasVuillaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested with Window 10 in Developper Mode, with Node 8.12, serverless@1.31.0 / serverless-plugin-typescript@1.1.5, running the shell in Administrator mode, and it worked.

@LadnovSasha
Copy link
Author

Hope this will be merged some day 🤞

@ThomasVuillaume
Copy link

Hope this will be merged some day 🤞

Yeah, @schickling if you have any news about that. In the meantime, I'm forking this with your patch @LadnovSasha

ThomasVuillaume added a commit to ThomasVuillaume/serverless-plugin-typescript that referenced this pull request Sep 26, 2018
Fix windows symlink creation serverless#109
ThomasVuillaume added a commit to ThomasVuillaume/serverless-plugin-typescript that referenced this pull request Sep 26, 2018
@ross2411
Copy link

Can someone please pull this in because it's causing me issues.

@chinmaygadre
Copy link

The change to index.js when done manually to files for version 1.1.5 is working properly on Windows 10.

@francoislg
Copy link

I fixed it by using ThomasVuillaume/serverless-plugin-typescript#master as a dependency...

When will this be merged...?

@stevegula
Copy link

For anyone who takes in ThomasVuillaume/serverless-plugin-typescript#master but continues to have trouble.. try removing your .build directory then attempt another deploy.

@ThomasEg
Copy link

ThomasEg commented Jan 9, 2019

Please pull this, it solves the problem(as long as you run it as admin at least)...

(i've testede the ThomasVuillaume/serverless-plugin-typescript#master version)

@aarym
Copy link

aarym commented Feb 13, 2019

Please could this get accepted as having to do a work around using another package forked from this.

@ThomasVuillaume
Copy link

Seems Prisma doesn't like Windows devs :D

(Psst, i've got a Linux too)

@LadnovSasha
Copy link
Author

I've published fork to npm, if someoune interested https://github.com/LadnovSasha/serverless-plugin-typescript

@jonasduever
Copy link

jonasduever commented Feb 14, 2019

Using a fork for such a "small" and easy-to-fix issue is not an adequate solution for me. :/
(Though I understand that you don't want to wait for a merge anymore.)

Edit: But since this project seems to be unmaintained anyway, it's maybe the only solution.

@LadnovSasha
Copy link
Author

LadnovSasha commented Feb 14, 2019

@jonasduever you can see in #130 that pr is still present

@dortega3000
Copy link

Not a lot of responses from prisma, I will try their slack channel. If not will fork and publish as a new serverless plugin thats actually updated!

@ThomasVuillaume
Copy link

Ok we'll wait for your info

@4fthawaiian
Copy link

.. is this still outstanding? I'm seeing this issue currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Symbolic Link fails on Windows