Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement User Apps #2807

Merged
merged 1 commit into from May 14, 2024
Merged

Implement User Apps #2807

merged 1 commit into from May 14, 2024

Conversation

GnomedDev
Copy link
Member

@GnomedDev GnomedDev commented Mar 18, 2024

Implements all the changes documented in the User Apps Change Log. This includes fun new models and fun new deprecation warnings.

@github-actions github-actions bot added the model Related to the `model` module. label Mar 18, 2024
@GnomedDev GnomedDev force-pushed the user-apps branch 6 times, most recently from ecec7b8 to a4ec842 Compare March 19, 2024 14:30
@GnomedDev GnomedDev changed the title WIP: Implement User Apps Implement User Apps Mar 19, 2024
@GnomedDev GnomedDev marked this pull request as ready for review March 19, 2024 14:40
@GnomedDev
Copy link
Member Author

This is now ready for review, I've not tested it yet as I don't have the time so that would be lovely if someone else could.

src/model/application/mod.rs Outdated Show resolved Hide resolved
src/model/application/command.rs Outdated Show resolved Hide resolved
src/model/application/command_interaction.rs Outdated Show resolved Hide resolved
src/model/application/component_interaction.rs Outdated Show resolved Hide resolved
src/model/application/interaction.rs Show resolved Hide resolved
src/model/application/interaction.rs Outdated Show resolved Hide resolved
src/model/event.rs Outdated Show resolved Hide resolved
src/model/application/mod.rs Outdated Show resolved Hide resolved
src/model/application/interaction.rs Outdated Show resolved Hide resolved
src/model/application/command.rs Outdated Show resolved Hide resolved
src/model/application/mod.rs Outdated Show resolved Hide resolved
@GnomedDev GnomedDev force-pushed the user-apps branch 2 times, most recently from 77c1d18 to 3115f86 Compare March 21, 2024 16:20
src/model/application/interaction.rs Outdated Show resolved Hide resolved
src/model/application/command_interaction.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@fgardt fgardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its working fine now apart from the one issue :)

src/model/application/interaction.rs Outdated Show resolved Hide resolved
@GnomedDev GnomedDev force-pushed the user-apps branch 2 times, most recently from 029eaea to 9410ec2 Compare April 30, 2024 13:49
Co-authored-by: Florian Gebhardt <me@fgardt.dev>
@GnomedDev
Copy link
Member Author

Merging this in as it isn't doing any good as a PR and has been tested by fgart, thanks!.

@GnomedDev GnomedDev merged commit 6a2c8e8 into serenity-rs:current May 14, 2024
22 checks passed
@GnomedDev GnomedDev deleted the user-apps branch May 14, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builder Related to the `builder` module. model Related to the `model` module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants