Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Searching for step text should return matching results #3449

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

jfstephe
Copy link
Contributor

@jfstephe jfstephe commented Apr 23, 2024

Summary of this PR

Currently it's not possible search manual test results by the step contents.

This has been resolved by adding a hidden column to the tables that can be searched, which contains all the step text of the scenario(s)/features(s). This is then, by default, included in the terms which can be searched.

Intended effect

This adds the ability to search manual test results by the step contents, but doesn't display the steps test.

How should this be manually tested?

Check the Filters work as expected, picking up the Steps as match values.
Normal regression testing.

Side effects

One strangeness was I had to put "width: 100%" on the HTML tables when hiding the steps text columns. I believe this is a bug in the js library being used.

Documentation

I believe this now works more like the user would expect.

Relevant tickets

#3438

Screenshots (if appropriate)

N/A

@jfstephe
Copy link
Contributor Author

NOTE: Related to #3448 (thanks for starting to address some of the issues!), I wasn't able to fully run the "mvnw clean verify" command successfully. It fails for me on jira related tests. I was able to build the parts that I've changed and test the app as best I can, but I think someone should give it a 'once over' at a minimum.

@wakaleo wakaleo merged commit a604a05 into serenity-bdd:main Apr 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants