Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Nix flake #1227

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add Nix flake #1227

wants to merge 1 commit into from

Conversation

a-h
Copy link

@a-h a-h commented May 3, 2024

This PR adds a Nix flake to the repo.

If you checkout the code and run nix develop inside the directory, you'll get a shell containing all of the dependencies required to work on deepface.

Running nix run inside the directory results in running the API which can be tested with a curl command, e.g.:

curl -H "Content-Type: application/json" \
  --data '{ "img_path": "/home/adrian/face-images/couple.jpg" }' \
  http://localhost:5000/represent

@@ -168,6 +168,9 @@ def __get_opencv_path(self) -> str:
Returns:
installation_path (str)
"""
if os.getenv("OPENCV_PATH", "") != "":
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer to get opencv path dynamically instead of env vars. Would you please revert this?

@@ -0,0 +1,22 @@
diff --git a/setup.py b/setup.py
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we move this to a folder instead of a root? otherwise it will make project messy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants