Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playsound -> nava #79

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

playsound -> nava #79

wants to merge 6 commits into from

Conversation

sadrasabouri
Copy link
Collaborator

Reference Issues/PRs

#49

What does this implement/fix? Explain your changes.

Due to the deprecation of playsound in Python, we made a sound library (nava) and switched to it 😄

@sadrasabouri sadrasabouri self-assigned this Feb 4, 2024
@sadrasabouri sadrasabouri added the enhancement New feature or request label Feb 4, 2024
@sadrasabouri sadrasabouri added this to the nafas v0.7 milestone Feb 4, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4eacae1) 98.07% compared to head (7ff3e40) 98.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #79      +/-   ##
==========================================
- Coverage   98.07%   98.00%   -0.06%     
==========================================
  Files           2        2              
  Lines         207      200       -7     
  Branches       22       21       -1     
==========================================
- Hits          203      196       -7     
  Misses          3        3              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sadrasabouri sadrasabouri marked this pull request as ready for review February 19, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants