New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sass dependency #77

Open

mdh wants to merge 1 commit into senny:master from mdh:remove-sass-dependency

mdh commented Sep 1, 2022

pdfjs_viewer-rails depends on sassc-rails, which hasnt been updated in 3 years. See https://github.com/sass/sassc-rails

sassc-rails in turn depends on sassc which is deprecated, see https://github.com/sass/sassc#sassc :

Warning: LibSass and SassC are deprecated. While it will continue to receive maintenance releases indefinitely, there are no plans to add additional features or compatibility with any new CSS or Sass features. Projects that still use it should move onto Dart Sass.

As there is very little css in this gem, why not get rid of dependency and just use plain css and allow people to use current sass implementations?


          Remove sass dependency

5cf10d2

mdh force-pushed the remove-sass-dependency branch from 56b6e43 to 5cf10d2 Compare

September 1, 2022 13:33

mdh mentioned this pull request

Any plans to use dart sass ? #76

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment