Sickbeard-mp4-automator merge #54
Conversation
Updated the modifications made in Sickbeard mp4 automator to the latest version of python-video-converter in such a way that they are backwards compatible with prior version unlike my last pull attempt. Changes made here add the ability to output files with multiple audio and subtitle tracks taking advantage of FFMPEGs -map function. Can pull from multiple or single sources. to create complex files with different tracks. Options are presented as nested dictionaries now but previously used style dictionaries are still compatible. Tests will need to be updated
|
Looks like a lot of my changes from the pull request I made a year ago have found their way into the project which is great. I wanted to update my script to use the latest version of your converter but I still need the greater level of functionality. This time however, I made some changes so that I don't break backwards compatibility. In my (albeit limited) testing my script is working as it previously did and I'm also able to use the readme example (using the original style options) with no problems either. |
|
nice! |
makes it more compliant with how the script functioned previously (allows it to pass some of the tests)
reorganizes commands
for python 3 compatibility
|
Updated the script some more to pass the various tests. had to modify some of the tests due to the way command line parameters being generated were different but its passing now. |
|
Any info on this? Any additional changes you require? |
-option to pass ffmpeg options before the inputfile and before the output file when needed. Being used for things like `-fix_sub_duration` and `-threads auto`. Defaults to none. -unicodedecodeerror exception catching which can occur with certain characters in file names breaking the script
-support for passing audio filters using the `filter` option -bitrates violating the min or max are approximated to their closest min/max value to avoid ffmpeg crashing due to absence of any bitrate setting -do not allow ac3 channels > 6. AC3 does not support any channel settings greater than 5.1 and will cause ffmpeg to abort
includes the minimum bitrate
ffprobe read video level
Updated the modifications made in Sickbeard mp4 automator to the latest
version of python-video-converter in such a way that they are backwards
compatible with prior version unlike my last pull attempt.
Changes made here add the ability to output files with multiple audio
and subtitle tracks taking advantage of FFMPEGs -map function. Can pull
from multiple or single sources. to create complex files with different
tracks.
Options are presented as nested dictionaries now but previously used
style dictionaries are still compatible.
Tests will need to be updated