Folder's support #12
Open
Folder's support #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonc27
commented
Dec 15, 2015
antonc27
commented
- Creation/deletion folders
- Navigation between folders
- Moving PDF documents to folder (to new folder or one level up)
- Related UTs for model
This reverts commit f6c1e9d.
- Added one test to verify that Folder files contains one PDF document
- Related UT
- Related UT added Note: Maybe it is better to write this functionality for File class, but we can assume that only PDF files will be moved around and also related thumbnail image must be moved in caches, so PDFDocument class is right place to do this for our purpose
- UT for one document moving
…tViewModel - Related UT
- Localization for en locale
TODO: better error handling
- Related UTs - Small refactoring for tests
…rchy - Related UTs
…in order to be more abstract
- Related UTs TODO: Better error handling
- Related UT
TODO 1: Some refactoring needed for abstraction layers TODO 2: Better error handling
- Related method for check added to ViewModel - Related UTs
Now related methods return success bool and can provide error information
- Related UTs for Folder and RootFolder
…wController - En localization updated - Refactoring for creation of action sheets
- Fill error if name is incorrect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.