SemaphoreViem implemented #364
Conversation
…re/release Yarn patch to change `changelogithub` output
…re/bump-version New NPM scripts to bump versions and publish NPM packages
…erifier-hardhat add hardhat task to deploy SemaphoreVerifier.sol
feat(identity): prepend hex strings with 0x
feat(identity): use sha512 to extract more entropy from message
This new package allows devs to fetch on-chain data by using a Semaphore subgraph or the Ethers library. BREAKING CHANGE: The code of the old `@semaphore-protocol/subgraph` package has been moved to the `@semaphore-protocol/data` package. re semaphore-protocol#256
…re/snarkjs-circomlibjs-types New Snarkjs/Circomlibjs type definitions
To take advantage of the reasoning in the Viem library.
|
Worse, I forgot to write the test. I'll go write one soon. |
|
Hey @inaridiy! Don't worry, take your time. Thank you so much. |
|
@vplasencia Accomplished! I have confirmed a successful build and test! |
| * @param network Chain object of viem. | ||
| * @param options Viem options. | ||
| */ | ||
| constructor(network: Chain = sepolia, options: ViemOptions = {}) { |
There was a problem hiding this comment.
It would be nice for devs to have a way to pass a valid chain without installing vite separately and importing viem/chains. The type here can be similar to EthersNetwork (i.e. strings), and the constructor could then use the right chain object based on that string. It would also be more consistent with SemaphoreEthers.
There was a problem hiding this comment.
I think the current implementation is better here, given its affinity with the Viem ecosystem.
There was a problem hiding this comment.
Makes sense. Do you think it makes sense to export those chains' objects in this package too?
There was a problem hiding this comment.
It certainly makes sense, and I find it a very nice contrast to SemaphoreEthers.
|
Thanks for the review. I will fix it now. |
|
I have made some corrections and added some comments |
Great, it looks like there's a small error in the API test. |
Description
SemaphoreViem is implemented.
Related Issue
#343
Does this introduce a breaking change?
Other information