[TEST ONLY] Use CSS modules instead of styled components #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajkl2533
force-pushed
the
css-modules
branch
from
6a7d76e
to
05f79a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is currently for testing purposes only. I want to test how big a performance impacts the use of native CSS in comparison to
styled-components.Found issues:
asproperty with a differently named prop (I usecomponentin this PR). The issue is that if a CSS component is extended with thestyled()function and theasproperty is applied to it, the styled-components swallow theasprop and the element is not used. Another side-effect of this is that no styling is applied to this extended component.