Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMB2: server - basic write support #4365

Merged
merged 1 commit into from Apr 28, 2024
Merged

Conversation

gpotter2
Copy link
Member

@gpotter2 gpotter2 commented Apr 25, 2024

This PR:

  • adds basic Write support in smbserver. Write isn't enabled by default.
  • adds SMB2 SetInfo implementation
  • remove a warning when using NTLM on cryptography 43+

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 72.04301% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 82.12%. Comparing base (e7ae05a) to head (7fe9da1).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4365      +/-   ##
==========================================
- Coverage   82.13%   82.12%   -0.02%     
==========================================
  Files         350      350              
  Lines       83136    83250     +114     
==========================================
+ Hits        68285    68366      +81     
- Misses      14851    14884      +33     
Files Coverage Δ
scapy/error.py 97.05% <100.00%> (ø)
scapy/layers/ntlm.py 88.29% <100.00%> (+0.15%) ⬆️
scapy/layers/smb2.py 87.43% <80.00%> (-0.14%) ⬇️
scapy/layers/smbserver.py 71.12% <61.53%> (+0.54%) ⬆️

... and 10 files with indirect coverage changes

@gpotter2
Copy link
Member Author

gpotter2 commented Apr 27, 2024

/packit build

@gpotter2 gpotter2 merged commit 942cdde into secdev:master Apr 28, 2024
33 checks passed
@gpotter2 gpotter2 deleted the smb-write branch April 28, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant