ISOTPNativeSocket improvements #4363
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4363 +/- ##
==========================================
- Coverage 82.20% 82.18% -0.02%
==========================================
Files 353 353
Lines 83529 83545 +16
==========================================
- Hits 68662 68661 -1
- Misses 14867 14884 +17
|
gpotter2
reviewed
Apr 27, 2024
…al variables for easier serialization. Also some docstrings to SuperSockets are added
polybassa
force-pushed
the
gh_isotp_native_socket_update
branch
from
8aae3e8
to
d842ebe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR update the ISOTPNativeSocket to store all arguments as internal variables for easier serialization. Also some docstrings to SuperSockets are added