Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UDS Scanner Update #4362

Merged
merged 2 commits into from Apr 27, 2024
Merged

UDS Scanner Update #4362

merged 2 commits into from Apr 27, 2024

Conversation

polybassa
Copy link
Contributor

This PR fixes #3942 and updates the UDS Scanner.

Additional feature, TesterPresentSender can be disabled during the send of a packet and the reception.

The argument inter allows to delay the sending of packets.

The Executor can now be started without a socket but with a given reconnect function to dynamically create a connection to the target after reset.

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 65.21739% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 82.11%. Comparing base (e7ae05a) to head (c2784c6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4362      +/-   ##
==========================================
- Coverage   82.13%   82.11%   -0.02%     
==========================================
  Files         350      350              
  Lines       83136    83174      +38     
==========================================
+ Hits        68285    68302      +17     
- Misses      14851    14872      +21     
Files Coverage Δ
scapy/contrib/automotive/scanner/configuration.py 88.63% <100.00%> (+0.13%) ⬆️
scapy/contrib/automotive/scanner/enumerator.py 92.65% <87.50%> (-0.50%) ⬇️
scapy/utils.py 72.92% <25.00%> (-0.17%) ⬇️
scapy/contrib/automotive/scanner/executor.py 85.65% <61.90%> (-2.56%) ⬇️

... and 6 files with indirect coverage changes

Copy link
Member

@gpotter2 gpotter2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@gpotter2 gpotter2 merged commit 5ac85af into master Apr 27, 2024
25 checks passed
@gpotter2 gpotter2 deleted the gh_scanner_update branch April 27, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UDS-Scanner - Add packet delay
2 participants