#4360: Add stop_filter parameter to SndRcvHandler #4361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added stop_filter param to SndRcvHandler.__init__(). Pass stop_filter to AsyncSniffer._run in SndRcvHandler._sndrcv_rcv. Check if SndRcvHandler.sniffer is running before stopping in SndRcvHandler._process_packet. Updated _DOC_SNDRCV_PARAMS documentation to include new parameter.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4361 +/- ##
==========================================
- Coverage 82.13% 82.02% -0.11%
==========================================
Files 350 350
Lines 83136 83137 +1
==========================================
- Hits 68280 68193 -87
- Misses 14856 14944 +88
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4360 for more details.
Added stop_filter param to SndRcvHandler.init().
Pass stop_filter to AsyncSniffer._run in SndRcvHandler._sndrcv_rcv.
Check if SndRcvHandler.sniffer is running before stopping in SndRcvHandler._process_packet.
Updated _DOC_SNDRCV_PARAMS documentation to include new parameter.
fixes #4360