Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnsweringMachines: better defaults, various fixes, more tests #4358

Merged
merged 1 commit into from Apr 27, 2024

Conversation

gpotter2
Copy link
Member

@gpotter2 gpotter2 commented Apr 21, 2024

This PR:

  • restores using sendp instead of send in AnsweringMachines. This works better in some cases (e.g. ICMP)
  • Test some answering machines that were yet untested (LdapPing_am)
  • Cleanup the NBNS answering machine and regroup with LdapPing_am
  • fixes Fix ICMPEcho_am description #4051

Copy link

codecov bot commented Apr 21, 2024

Codecov Report

Attention: Patch coverage is 90.38462% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 82.17%. Comparing base (cd2fed9) to head (744e727).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4358      +/-   ##
==========================================
+ Coverage   82.13%   82.17%   +0.04%     
==========================================
  Files         350      350              
  Lines       83136    83155      +19     
==========================================
+ Hits        68280    68334      +54     
+ Misses      14856    14821      -35     
Files Coverage Δ
scapy/ansmachine.py 67.93% <100.00%> (ø)
scapy/layers/dhcp.py 83.49% <100.00%> (-0.06%) ⬇️
scapy/layers/dhcp6.py 86.08% <100.00%> (+0.19%) ⬆️
scapy/layers/dot11.py 91.40% <100.00%> (ø)
scapy/layers/inet.py 71.69% <100.00%> (+0.06%) ⬆️
scapy/layers/netbios.py 92.42% <100.00%> (+7.28%) ⬆️
scapy/layers/dns.py 88.72% <84.61%> (+1.10%) ⬆️
scapy/layers/ldap.py 58.81% <86.95%> (+4.96%) ⬆️

... and 4 files with indirect coverage changes

polybassa
polybassa previously approved these changes Apr 24, 2024
@gpotter2 gpotter2 changed the title Use sendp in AnsweringMachines by default AnsweringMachines: better defaults, various fixes, more tests Apr 27, 2024
@gpotter2 gpotter2 added this to the 2.6.0 milestone Apr 27, 2024
@polybassa
Copy link
Contributor

Nice PR, LGTM

@gpotter2 gpotter2 merged commit 01aeed2 into secdev:master Apr 27, 2024
23 checks passed
@gpotter2 gpotter2 deleted the ans-sendp branch April 27, 2024 19:22
- Use sendp by default. This works better in some cases (e.g. ICMP)
- Test some answering machines that were yet untested (LdapPing_am)
- Cleanup the NBNS answering machine and regroup with LdapPing_am
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants