Fix UTCTimeField before epoch on Windows #4357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpotter2
force-pushed
the
utctimefield-win
branch
from
b8f4da2
to
2362250
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4357 +/- ##
==========================================
- Coverage 82.13% 82.12% -0.01%
==========================================
Files 350 350
Lines 83136 83183 +47
==========================================
+ Hits 68280 68314 +34
- Misses 14856 14869 +13
|
polybassa
previously approved these changes
Apr 24, 2024
gpotter2
force-pushed
the
utctimefield-win
branch
from
2362250
to
7ec34e5
Compare
This fixes UTCTimeField that have a value before 1970 on Windows. fixes secdev#4308
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
fixes #4308