New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LLDP add PoE TLV #4346
base: master
Are you sure you want to change the base?
LLDP add PoE TLV #4346
Conversation
Unit test failed because |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4346 +/- ##
==========================================
- Coverage 82.03% 81.50% -0.53%
==========================================
Files 350 350
Lines 82888 83230 +342
==========================================
- Hits 67994 67836 -158
- Misses 14894 15394 +500
|
4a98af2
to
bc888eb
Compare
Added PoE measure TLV. Again, macos tests are failing because tshark is not installed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR. Please make use of ScalingFields for physical units
0101baa
to
c2d53f7
Compare
Changed to use |
Found the mistake in |
Double-checked |
Checklist:
cd test && ./run_tests
ortox
)This PR adds PoE (IEEE802.3bt) organization specific TLVs for LLDP layer
Different versions of PoE TLVs were added as separate classes instead of using
ConditionalField
to allow the user explicitly instantiate the desired TLV version.