Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix endianess typo #4331

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RoboSchmied
Copy link

fix typo endianess -> endianness

Signed-off-by: RoboSchmied <github@roboschmie.de>
Copy link

codecov bot commented Mar 23, 2024

Codecov Report

Merging #4331 (cd44255) into master (f919a6a) will decrease coverage by 0.38%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4331      +/-   ##
==========================================
- Coverage   81.67%   81.30%   -0.38%     
==========================================
  Files         350      350              
  Lines       82884    82884              
==========================================
- Hits        67699    67387     -312     
- Misses      15185    15497     +312     
Files Coverage Δ
scapy/contrib/pnio_rpc.py 94.67% <100.00%> (ø)
scapy/contrib/rtps/common_types.py 95.27% <100.00%> (ø)
scapy/layers/dcerpc.py 90.90% <100.00%> (ø)

... and 27 files with indirect coverage changes

@gpotter2
Copy link
Member

I have mixed feelings about this.

On the one hand this is technically correct, on the other I have mixed feelings merging a PR that's part of a 47 batch that only fixes a typo on the word "endianness". That's.. almost spammy, and reminds me of what people did to get PRs in for Hacktoberfest (or similar contests).

What are you doing that for ? or what's the big deal with endianness :p

image

@gpotter2 gpotter2 changed the title Fix: 15 typos Fix endiness typo Mar 24, 2024
@gpotter2 gpotter2 changed the title Fix endiness typo Fix endianess typo Mar 24, 2024
@RoboSchmied
Copy link
Author

RoboSchmied commented Mar 25, 2024

I have mixed feelings about this.

On the one hand this is technically correct, on the other I have mixed feelings merging a PR that's part of a 47 batch that only fixes a typo on the word "endianness".

@gpotter2
Thank you for your review. There are also functional and other changes in my PRs.

That's.. almost spammy, and reminds me of what people did to get PRs in for Hacktoberfest (or similar contests).

What are you doing that for ? or what's the big deal with endianness :p

Its no contest, no medal hunt.

Its a test + dev of a bot that prepares everything up to the pull request. The review and PR is done manually by me.
The endianess is only used as an test case: an unique and often made typo easy to find and to fix.
So I learn much about the big reops, PR formatting, code style and so on.

Why not? This is what bots are made for. ;)

Greetings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants