Add SSL support for DoIP sockets #4327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4327 +/- ##
==========================================
+ Coverage 82.20% 82.21% +0.01%
==========================================
Files 353 353
Lines 83529 83586 +57
==========================================
+ Hits 68662 68719 +57
Misses 14867 14867
|
|
Could you add a PR summary? Thanks. |
|
@gpotter2 Done |
gpotter2
previously approved these changes
Apr 27, 2024
Done! |
gpotter2
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds SSL functionality for DoIP Sockets.
In order to provide SSL functionality, the
recv()function of existing DoIP socket needed to be refactored.The SSL DoIP Sockets work the same way as existing DoIP sockets, only a SslContext has to be provided.
Additionally, this PR adds unit tests for the new recv() function and the SSL DoIPSockets.