Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*BSD unit tests #4269

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

*BSD unit tests #4269

wants to merge 1 commit into from

Conversation

guedou
Copy link
Member

@guedou guedou commented Feb 6, 2024

This PR makes sure that all unit tests pass on *BSD.

@guedou guedou added this to the 2.6.0 milestone Feb 6, 2024
@guedou guedou self-assigned this Feb 6, 2024
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Merging #4269 (807657a) into master (5fa6428) will increase coverage by 0.02%.
Report is 15 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4269      +/-   ##
==========================================
+ Coverage   49.60%   49.62%   +0.02%     
==========================================
  Files         341      341              
  Lines       76081    76081              
==========================================
+ Hits        37742    37758      +16     
+ Misses      38339    38323      -16     

see 4 files with indirect coverage changes

@@ -10,7 +10,7 @@
# minversion = 4.0
skip_missing_interpreters = true
# envlist = default when doing 'tox'
envlist = py{37,38,39,310,311,312}-{linux,bsd,windows}-non_root
envlist = py{37,38,39,310,311,312}-{linux,bsd,windows}-{non_root,root}
Copy link
Member

@gpotter2 gpotter2 Mar 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want this?

I think it would be nice that simply doing tox with no parameter actually ran the tests. The current default would only run non-root tests which is to me fine. It's arguable it could be root tests, but I don't think it needs both.

That being said, it's currently unusable and fails miserably due to tox-dev/tox#3153. I'm slowly growing tired of tox.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like to type tox without specifying anything, then go and do something else. root used to be in envlist, that is why I changed it back in this PR. I don't have strong arguments to add it back, but I find this useful.

@guedou
Copy link
Member Author

guedou commented May 8, 2024

On NetBSD 10, all unit tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants