Show NTP version and mode instead of question marks #3944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 1e48e13 NTP switched to dispatch_hook and all the fields including "version" and "mode" moved to the NTP subclasses. This PR adjusts the mysummary method accordingly. With this patch applied tshark() prints something like ``` 17 Ether / IP / UDP / NTP v4, client 18 Ether / IP / UDP / NTP v4, server ``` instead of ``` 17 Ether / IP / UDP / NTP v??, ?? 18 Ether / IP / UDP / NTP v??, ?? ``` It's a follow-up to 1e48e13
Codecov Report
@@ Coverage Diff @@
## master #3944 +/- ##
==========================================
- Coverage 81.64% 81.15% -0.49%
==========================================
Files 326 326
Lines 75429 75429
==========================================
- Hits 61582 61216 -366
- Misses 13847 14213 +366
|
gpotter2
approved these changes
Mar 25, 2023
|
Thanks for the PR ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 1e48e13 NTP switched to dispatch_hook and all the fields including "version" and "mode" moved to the NTP subclasses. This PR adjusts the mysummary method accordingly.
With this patch applied tshark() prints something like
instead of
It's a follow-up to 1e48e13