Update frame's background #172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iris-garcia
force-pushed
the
update-background
branch
from
4672eb8
to
6e92c5b
Compare
Dash 2.18.0 subsumed dash-functional, and company-box no longer loads dash-functional, but it still lists old versions of dash and dash-functional as dependencies, which can cause issues. While at it, require the latest version 2.19.0 of Dash. Re: sebastiencs#152, sebastiencs#153, sebastiencs#156, sebastiencs#157, sebastiencs#161, sebastiencs#168, sebastiencs#170.
|
I'd love to see this merged. |
sebastiencs
added a commit
that referenced
this pull request
Sep 9, 2022
Delete existing frames to rebuild them from scratch. They will use the colors of the new theme.
|
Hi @iris-garcia , thanks for your PR ! The call to In 82c1a30 I made an alternate solution: it will delete the frames (of company-box) every time the theme is changing. Could you, or @jthaman , confirm that it works ? Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #148.