Enabled the use of clippy for the project. #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
reviewed
Jun 12, 2023
* Run clippy in CI
- Require SAFETY documents in front of every unsafe block.
- Set MSRV version in clippy.toml to avoid lints that break the MSRV
* Several fixes to make clippy happy
- Ran cargo clippy --fix
- Added some clippy exceptions
- Added many SAFETY comments to unsafe blocks
* Tested MIRAI static analyzer to find "unintentional panics"
- added some debug-build overflow checks to satsify MIRAI
- Currently, installing MIRAI takes way too long in CI so it is
disabled for now. Need to find a way to cache this.
Signed-off-by: Michael Rodler <mrodler@amazon.de>
seanmonstar
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disabled for now. Need to find a way to cache this (maybe a custom github action or docker container).