Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msrv: test aarch64 #142

Merged
merged 4 commits into from May 1, 2023
Merged

msrv: test aarch64 #142

merged 4 commits into from May 1, 2023

Conversation

AaronO
Copy link
Contributor

@AaronO AaronO commented Apr 29, 2023

First commit should intentionally fail in CI, then use a cfg guard to fallback to swar instead of neon

NOTE: on M1 swar is surprisingly "only" ~30% slower than neon (i.e: ~100ns/iter vs ~70ns/iter for req/req).

Unblocks #141 (since we can punt raising MSRV)

@AaronO
msrv: test aarch64
2f79be8 
First commit should intentionally fail in CI
@AaronO
tweaks
ea46cf5
@AaronO
version guard neon
6f2a063
@AaronO AaronO mentioned this pull request Apr 29, 2023
Merged
@seanmonstar seanmonstar merged commit efcdae7 into seanmonstar:master May 1, 2023
33 checks passed
@AaronO AaronO deleted the msrv/test-aarch64 branch May 1, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AaronO @seanmonstar