refactor: cleaner header parsing #139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronO
force-pushed
the
refactor/header-parsing
branch
3 times, most recently
from
c9d4c3a
to
9c27ddc
Compare
AaronO
force-pushed
the
refactor/header-parsing
branch
from
9c27ddc
to
637637b
Compare
|
Happy to see those gnarly macros cleaned up. I put those together when I was very new at Rust, and slowly grew them poorly, and understanding them whenever I came back to them was always confusing. I'm guessing moving around the enums makes them slightly smaller. You said there was a measurable perf improvement? |
Builds off seanmonstar#134 (swar), seanmonstar#138 (Bytes cursor) Cleaner, faster and less macros ! - Broke down header-parsing into clean conceptual steps (whilst being faster !) - Added InnerResult allowing for idiomatic `?` early-exits, removing need for parsing-helper macros - Removed macros.rs, leaving only `byte_map!` (response header-parsing macros should become functions)
AaronO
force-pushed
the
refactor/header-parsing
branch
from
637637b
to
d9cf6a3
Compare
|
Just checking in here, did you want to get this merged before we shoot out the new release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds off #134 (swar), #138 (Bytes cursor)
Cleaner, faster and less macros !
Key changes
?early-exits, removing need for parsing-helper macrosbyte_map!(response header-parsing macros should become functions)TODO