Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Extend sealer save to support multi-image-archive and tmp-dir #2193

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cubxxw
Copy link
Collaborator

@cubxxw cubxxw commented Apr 20, 2023

Signed-off-by: Xinwei Xiong(cubxxw) 3293172751nss@gmail.com

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@cubxxw cubxxw added the feature label Apr 20, 2023
@cubxxw cubxxw force-pushed the feature/save-load-flag branch 3 times, most recently from 86764e8 to c5825df Compare April 21, 2023 10:40
feature: Extend the save flag option and function

Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>

fix: multi-image-archive

Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
@kakaZhou719
Copy link
Member

@cubxxw ,how can we support to set tmp dir for load and save cmd. i assume we need below 3 steps:

  1. add flag
  2. use it to set sealer tmp dir
  3. use it to set buildah tmp dir

could pls recheck our code to implement it?
more to see: #2147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants