feature: Add flags, and update the necessary packages #2169
Conversation
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2169 +/- ##
==========================================
- Coverage 18.89% 12.20% -6.70%
==========================================
Files 96 263 +167
Lines 8918 22420 +13502
==========================================
+ Hits 1685 2736 +1051
- Misses 7003 19302 +12299
- Partials 230 382 +152
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 176 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
cmd/sealer/cmd/image/load.go
Outdated
| flags.BoolVarP(&loadOpts.Quiet, "quiet", "q", false, "Suppress the output") | ||
| flags.StringVar(&loadOpts.TmpDir, "tmp-dir", "", "set temporary directory when load image. if not set, use system`s temporary directory") | ||
| flags.StringVar(&loadOpts.TmpDir, "tmp-dir", "", "Set temporary directory when load image. use system temporary directory is not (/var/tmp/)at present ") |
There was a problem hiding this comment.
Set temporary directory when load image. use system temporary directory(/tmp/) if not present.
|
@cubxxw please make sure the CI passed |
github-actions
bot
added
the
ImageBuilding
cubxxw
changed the title
Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com> Adjust the pkg package Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com> Adjust the pkg package Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com> backup stash@2 Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com> feature: Add flags, and update the necessary packages Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com> fix: avoid useless packets affecting cicd Signed-off-by: Xinwei Xiong(cubxxw) <3293172751nss@gmail.com>
cubxxw
force-pushed
the
feature/add-load-flag
branch
from
1065d4f
to
402bfc5
Compare
|
@cubxxw , i see a lot of changes. could you pls split it to make our pr more pure?
|
Signed-off-by: Xinwei Xiong(cubxxw) 3293172751nss@gmail.com
Describe what this PR does / why we need it
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
❯ go version go version go1.18.1 linux/amd64 ❯ sealer version {"gitVersion":"unknown","gitCommit":"21fa921db","buildDate":"2023-04-20 12:07:40","goVersion":"go1.18.1","compiler":"gc","platform":"linux/amd64"} ❯ go version go version go1.17 linux/amd64 ❯ sealer version {"gitVersion":"unknown","gitCommit":"1065d4f66","buildDate":"2023-04-20 12:12:44","goVersion":"go1.17","compiler":"gc","platform":"linux/amd64"}Special notes for reviews