[WIP]feature: add oci registry #2071
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ImageBuilding
kakaZhou719
reviewed
Mar 10, 2023
14 tasks
Signed-off-by: jsparter <1084237763@qq.com>
fengxsong
reviewed
May 22, 2023
| if err := getDestDir(destImageName); err != nil { | ||
| return err | ||
| } | ||
| err := skopeo.Copy(srcImageName, destImageName, creds) |
There was a problem hiding this comment.
This approach will make it impossible to reuse layers that may be duplicated in all images while building new oci images. that is, the new built image will become large than before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Already implement scenario1、2 of #1940. This pr needs to work with basefs pr 40
Now we can use image cache when build stage by specify registryType as "oci" in json file: $HOME/.sealer/config，and run with new basefs after basefs pr 40
config file example:
Does this pull request fix one issue?
Part of #1940 、#2001
Describe how you did it
Describe how to verify it
Special notes for reviews