Remove python2 support for core build tools #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depedencies on Python2/3 cross support (such as six, past and future) are removed as only Python3 is supported at this point. Fewer external deps is a good thing. Signed-off-by: Ben Leslie <benno@brkawy.com> Signed-off-by: Ivan Velickovic <i.velickovic@unsw.edu.au>
Ivan-Velickovic
force-pushed
the
remove_python_deps
branch
from
6ac30c9
to
d0eaf73
Compare
lsf37
approved these changes
May 2, 2024
lsf37
added
cleanup
Indanz
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We haven't supported Python2 for a while and these dependencies are all apart of the standard library of Python3 now so they are no longer needed.
This means compiling seL4 itself does not depend on six, past, or future anymore which means less external dependencies.
The manual does an
import sixand I believe some of the CapDL tooling still depends on these packages so there would be a few more PRs necessary before dropping them from the general seL4 dependency list.