Python: fix errors found by type checker #1205
Open
+35
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axel-h
added
cleanup
axel-h
changed the title
axel-h
force-pushed
the
patch-axel-11-1
branch
6 times, most recently
from
ebe72ab
to
d51f5b6
Compare
Signed-off-by: Axel Heider <axelheider@gmx.de>
Indanz
reviewed
May 3, 2024
| @@ -189,7 +189,7 @@ def create_c_header_file(config, kernel_irqs: List, kernel_macros: Dict, | |||
| kernel_regions: List, physBase: int, physical_memory, | |||
| outputStream): | |||
|
|
|||
| jinja_env = jinja2.Environment(loader=jinja2.BaseLoader, trim_blocks=True, | |||
| jinja_env = jinja2.Environment(loader=jinja2.BaseLoader(), trim_blocks=True, | |||
There was a problem hiding this comment.
Surely BaseLoader is the default, why pass it at all?
There was a problem hiding this comment.
Good point, I just fixed the warning here. Explicitly setting this parameter might come from history following recommendations from older versions. Will have a look into this.
tools/hardware/fdt.py
Outdated
Comment on lines
94
to
98
| node = self.get_path(path) | ||
| if node is not None: | ||
| ret.append(node) | ||
|
|
There was a problem hiding this comment.
How can this return None?
Also, empty line added unnecessarily.
There was a problem hiding this comment.
The static type annotation checker reported this based on the signatures. In this PR I left out addressing the semantics also.
tools/hardware/utils/cpu.py
Outdated
Comment on lines
20
to
21
| if cpus_node is None: | ||
| return [] | ||
|
|
There was a problem hiding this comment.
It seems better if get_path returns an empty array than checking for None everywhere...
Removing the function because it is not use anywhere. Not cloning the owner seems an inconsistent behavior anyway. Signed-off-by: Axel Heider <axelheider@gmx.de>
Support comparisson operations for derived objects only, and fail for anything else. Currently there is no use case that requires duck typing and stricter type checking allows catching potential errors. Signed-off-by: Axel Heider <axelheider@gmx.de>
Signed-off-by: Axel Heider <axelheider@gmx.de>
Signed-off-by: Axel Heider <axelheider@gmx.de>
Signed-off-by: Axel Heider <axelheider@gmx.de>
The DTB appears broken if an item in the chosen node can't be resolved. Raise an error instead of silently ignoring this, as it might be a typo that must be fixed. Otherwise, non-existing items should be removed from the chosen node in a overlay file. Signed-off-by: Axel Heider <axelheider@gmx.de>
The return values is not used by any known callers of this function. There is no sane generic way to handle return values on recursive invocations, thus any visitor must handle this internally. This is doable in Python easily, so there is no need for an additional explicit context parameter either. Signed-off-by: Axel Heider <axelheider@gmx.de>
Element 0 may not exist if the string is empty. Signed-off-by: Axel Heider <axelheider@gmx.de>
Lists are ordered and enumerate() provides the index. Signed-off-by: Axel Heider <axelheider@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix errors found by type checker while working on #797