Initial support for the 'jena' candidate #615
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
berezovskyi
changed the title
marc0der
requested changes
Nov 27, 2022
| def migration001(implicit db: MongoDatabase): Candidate = { | ||
| Candidate( | ||
| candidate = CandidateName, | ||
| name = "Apache Jena", |
There was a problem hiding this comment.
Let's just drop the Apache here for brevity.
| import com.mongodb.client.MongoDatabase | ||
| import org.bson.Document | ||
|
|
||
| @ChangeLog(order = "100") |
There was a problem hiding this comment.
When last I counted, we only had 73.
| candidate = CandidateName, | ||
| name = "Apache Jena", | ||
| description = | ||
| "Apache Jena (or Jena in short) is a free and open source Java framework for building semantic web and Linked Data applications. The framework is composed of different APIs and CLI tools interacting together to process RDF data.", |
There was a problem hiding this comment.
I'd leave out the bit in brackets (or Jena in short).
|
Thank you, @marc0der. I just updated the PR as you requested. I am not a Jena maintainer but can I reach out to the dev mailing list if you think the Vendor API (https://sdkman.io/vendors I presume) is a better route. Can we consider this a future improvement or do you strongly prefer the use of Vendor API instead? |
|
@marc0der did you have a chance to check out the changes I did as you requested? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jena and RDF4J are the two most popular semantic web libraries. The CLI tools include converting RDF formats, querying graphs ad-hoc and loading large files into the DB.
brew install jenawill give you an install to explore:Used ActiveMQ migration as a template. This is my first PR to SDKMAN, looking forward to your feedback.