Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 5.2] compaction: improve partition estimates when using garbage collected sstables #18623

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented May 11, 2024

When a compaction strategy uses garbage collected sstables to track expired tombstones, do not use complete partition estimates for both the regular output sstables and the temporary sstables. Instead split the partition estimate between the two based on the droppable tombstone ratio estimate.

Fixes #18283

(cherry picked from commit 36b98d8)

Refs #18465

When a compaction strategy uses garbage collected sstables to track
expired tombstones, do not use complete partition estimates for them,
instead, use a fraction of it based on the droppable tombstone ratio
estimate.

Fixes #18283

Signed-off-by: Lakshmi Narayanan Sreethar <lakshmi.sreethar@scylladb.com>
(cherry picked from commit 36b98d8)

# Conflicts:
#	compaction/compaction.cc
@mergify mergify bot requested a review from nyh as a code owner May 11, 2024 21:45
@mergify mergify bot added the conflicts label May 11, 2024
Copy link
Author

mergify bot commented May 11, 2024

Cherry-pick of 36b98d8 has failed:

On branch mergify/copy/branch-5.2/pr-18465
Your branch is up to date with 'origin/branch-5.2'.

You are currently cherry-picking commit 36b98d8bfb.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   compaction/compaction.cc

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot marked this pull request as draft May 11, 2024 21:46
@lkshminarayanan
Copy link
Member

Replaced by #18659

@mergify mergify bot deleted the mergify/copy/branch-5.2/pr-18465 branch May 14, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant