Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(usersettings): add ability to hide tags on details page #3810

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

jordanjones98
Copy link
Contributor

@jordanjones98 jordanjones98 commented Mar 12, 2024

fix #3350

Description

Add ability for a user to collapse tags on the movie/tv detail page from a checkbox. I made the text the same size as the season text, maybe it should be smaller? Up to do whatever there.

[question] This is at the user level right now, because that is where the other PR had it, should it be a server level setting?

Screenshot (if UI-related)

Collapse Tags checkbox in user settings page
image

Collapse Tags checkbox unchecked (default)
image

Collapse Tags checkbox checked
image

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

@sct
Copy link
Owner

sct commented Mar 13, 2024

What about instead of just hiding it entirely, we add an option to auto collapse the tags? That way users could still see them if they want to?

@jordanjones98
Copy link
Contributor Author

What about instead of just hiding it entirely, we add an option to auto collapse the tags? That way users could still see them if they want to?

Yeah I like that idea, I can implement that.

@jordanjones98
Copy link
Contributor Author

What about instead of just hiding it entirely, we add an option to auto collapse the tags? That way users could still see them if they want to?

I updated it, I am probably going to pull out UI into it's own component so it is in one spot, but that is a tomorrow problem. Functionality and UI is there right now.

@jordanjones98
Copy link
Contributor Author

@sct Updated to use a shared component. The only configurable thing besides the tags is the type of movie or tv in the URL. I think just a prop with those two options is safe, but if you would rather do it a different way let me know. That migration should be fixed now too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide tags from detail page
2 participants