-
-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for requesting "Specials" for TV Shows #3724
base: develop
Are you sure you want to change the base?
feat: add support for requesting "Specials" for TV Shows #3724
Conversation
Can we remove the |
2f3c080
to
3b0eb44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sct I made a commit that was responsible for undoing yarn.lock
update. Thanks for letting me know.
@westdom Thank you for reviewing the PR. I responded to your suggestions, but made no code changes. Let me know if you have any more thoughts. Otherwise, I believe the conversations can be marked as resolved.
Any updates on this? |
This commit is responsible for adding support in Overseerr for requesting "Special" episodes for TV Shows. This request has become especially pertinent when you consider shows like "Doctor Who". These shows have Specials that are critical to understanding the plot of a TV show. fix sct#779
0a857e8
to
919a384
Compare
@Panda260 No new updates.. I've updated the branch to be rebased on top of the |
Description
This pull request is responsible for adding support in Overseerr for requesting "Special" episodes for TV Shows. This request has become especially pertinent when you consider shows like "Doctor Who". These shows have Specials that are critical to understanding the plot of a TV show.
Screenshot (if UI-related)
The TV Show Page
If you navigate to any show with Specials, you'll see the "Specials" season just before "Season 1".
NOTE: In this example, Doctor Who has 13 Seasons + Specials. However, in the header for the TV show, we STILL say that the show has 13 seasons (we don't include specials as a "Season" in the headers).
The TV Show Page (Request Modal)
NOTE: Instead of having the table say
Season 0
which it would normally say for the Specials season, it says "Specials". Whether it should saySeason 0
orSpecials
is a discussion that could be worth having for this PR, but I personally went withSpecials
for more user-friendliness.The TV Show Page (Manage Series Sidebar)
NOTE: Instead of having the Badge say
0
which it would normally say for the Specials season, it says "Specials". Whether it should say0
orSpecials
is a discussion that could be worth having for this PR, but I personally went withSpecials
for more user-friendliness.The Requests Page
To-Dos
yarn build
yarn i18n:extract
Issues Fixed or Closed