-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: request 4K media with the title card #3636
base: develop
Are you sure you want to change the base?
Conversation
1 flaky test on run #2112 ↗︎
Details:
cypress/e2e/settings/discover-customization.cy.ts • 1 flaky test
Review all test suite changes for PR #3636 ↗︎ |
. was on version that didn't contain this update. sorry everyone |
Hmmmm just tested this on my end and it's working fine. The title card on discover and the movies tab use the same component. Not sure what is going on from your side to be honest. |
Ok, sorry everyone. I'm on develop docker container version but didn't realize this has not been pushed yet. Is there an easy way I can pull a docker container containing this update? Majority of my content is 4K and it is very difficult to browse without the available icon. |
Yes I didn't realize at the time. Apologies for that and I've edited my posts everywhere to reflect. Thank you for adding this though, this feature would be amazing to have since the majority of my library is 4K. I get bad requests for 1080p content when the 4K exists simply because users can't easily tell that it already exists. |
Description
The main focus of this PR is to give the user the ability to request 4K media on the discover screen. Before, users were only able to request non-4K media through the title card. Now if non-4K media is already available and the server has 4K requesting enabled, the 4K request button will show. Also, a status badge will now show if you only have 4K media available.
There are some cases where the user might not have a non-4K server and two 4K servers so a check was added for this scenario.
Screenshot (if UI-related)
To-Dos
yarn build
Issues Fixed or Closed