WIP: Timeout #11
Open
WIP: Timeout #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we add tests? @arybczak |
arybczak
reviewed
Jan 19, 2023
| @@ -87,6 +104,8 @@ newPool pc = do | |||
| error "poolCacheTTL must be at least 0.5" | |||
| when (poolMaxResources pc < 1) $ do | |||
| error "poolMaxResources must be at least 1" | |||
| when (maybe False (< 0) (acquireResourceTimeout <$> poolTimeoutConfig pc)) $ do | |||
| error "acquireResourceTimeout must be at least 0" | |||
There was a problem hiding this comment.
I'd argue it should be more than 0 :)
| @@ -24,6 +26,9 @@ data Pool a = Pool | |||
| , reaperRef :: !(IORef ()) | |||
| } | |||
|
|
|||
| getPoolTimeoutConfig :: Pool a -> Maybe TimeoutConfig | |||
There was a problem hiding this comment.
I'd argue we can do without this helper function.
arybczak
reviewed
Jan 19, 2023
| data TimeoutConfig = TimeoutConfig | ||
| { acquireResourceTimeout :: Int | ||
| -- ^ Time to await, microseconds | ||
| , timeoutLabel :: String |
There was a problem hiding this comment.
Wouldn't it be better to provide a value that should be thrown as exception here instead of a label?
Then you can also get rid of the TimeoutException.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #10