Update just screeps-api #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: Tests were broken before and after the updates so I did a diff on the
distoutput before and after and it's identical. Probably safe.The
screeps-apilibrary updated deps recently to handle some vulnerabilities withaxiosand other libraries. This PR updates thescreeps-apito latest to get those and other updates.Unfortunately, I couldn't get the tests working before I touched anything and I spent more time than I probably should have trying to get them working with no success. Barring that, I did a comparison of the resulting
distoutput before and after this update (using WinMerge, if you're curious) and the outputs were identical, so it seems safe.FWIW, I was curious what it looked like to update every dep to latest. There were a couple of small issues that were easily fixed, and the resulting
distoutput seems functionally equivalent but has a few differences in how it was bundled, which should probably be tested more thoroughly by someone more familiar with the library than I am.I created a PR for that as well, if someone wants to take a look at it. Let me know.