Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test targets and delete EOL Ruby version test target #469

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add test targets and delete EOL Ruby version test target #469

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9342339
Add test targets of Ruby 3.1 and 3.2
Mar 20, 2023
b49fae9
Delete test targets of Ruby EOL version
Mar 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
41 changes: 26 additions & 15 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,21 +19,6 @@ jobs:
fail-fast: false
matrix:
include:
- ruby: 2.1
gemfile: gems/rails3.gemfile
- ruby: 2.2
- ruby: 2.3
- ruby: 2.4
- ruby: 2.5
- ruby: 2.6
- ruby: 2.6
gemfile: gems/typhoeus.gemfile
test_features: "typhoeus"
- ruby: 2.6
gemfile: gems/octoshark.gemfile
- ruby: 2.6
gemfile: gems/rails3.gemfile
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we also delete those old gemfiles ?

and bump the minimum requirement in the scout_apm_ruby.gemspec ?

bundler: 1.17.3
- ruby: 2.7
- ruby: 2.7
prepend: true
Expand All @@ -50,6 +35,32 @@ jobs:
- ruby: 3.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.0 needs to be quoted "3.0" otherwise, latest 3.x is used

gemfile: gems/sidekiq.gemfile
test_features: "sidekiq_install"
- ruby: 3.1
- ruby: 3.1
prepend: true
- ruby: 3.1
gemfile: gems/instruments.gemfile
test_features: "instruments"
- ruby: 3.1
gemfile: gems/instruments.gemfile
prepend: true
test_features: "instruments"
- ruby: 3.1
gemfile: gems/sidekiq.gemfile
test_features: "sidekiq_install"
- ruby: 3.2
- ruby: 3.2
prepend: true
- ruby: 3.2
gemfile: gems/instruments.gemfile
test_features: "instruments"
- ruby: 3.2
gemfile: gems/instruments.gemfile
prepend: true
test_features: "instruments"
- ruby: 3.2
gemfile: gems/sidekiq.gemfile
test_features: "sidekiq_install"

env:
BUNDLE_GEMFILE: ${{ matrix.gemfile }}
Expand Down