Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change MAXNUMONOFF #166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matteobachetti
Copy link
Contributor

Resolve #77

@scottransom
Copy link
Owner

@matteobachetti Sorry about the delay on this. I must have missed the notification when you did that.

I think it would be OK to increase MAXNUMONOFF fairly substantially, but I'm not willing to many millions, as you have it here. The reason is that in makeinf.h the INFODATA structure has a static size which includes a double precision array of:

double onoff[MAXNUMONOFF*2];

So that means each INFODATA structure would be over 6GB in size!

The proper way to do this would be to make INFODATA dynamically sized, but that greatly complicates things -- especially passing those structures to/from Python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change MAXNUMONOFF
2 participants