Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change MAXNUMONOFF #77

Open
matteobachetti opened this issue Jan 20, 2017 · 3 comments · May be fixed by #166
Open

Change MAXNUMONOFF #77

matteobachetti opened this issue Jan 20, 2017 · 3 comments · May be fixed by #166

Comments

@matteobachetti
Copy link
Contributor

Hi @scottransom, is there a specific reason why MAXNUMONOFF is hardcoded to 40?

For X-ray data from some missions, it would be very helpful to increase it, so that we can exclude from the analysis all the frequent gaps due to telemetry and orbital occultation, SAA passages, etc, and get more consistent statistics.

(I'm tagging here also @ferrigno)

@scottransom
Copy link
Owner

Nope, not at all. Actually, the ON/OFF pairs are something that I think is rarely if ever used in PRESTO. If you use it, I'd happily accept a patch to make that dynamic (or have a higher fixed number).

@tanumanghosh
Copy link

Hi, @scottransom, and @matteobachetti, was this issue resolved? Is it possible to change the number for MAXNUMONOFF in the current PRESTO version?

@matteobachetti matteobachetti linked a pull request May 30, 2022 that will close this issue
@scottransom
Copy link
Owner

@tanumanghosh I haven't touched this in PRESTO. I suspect that you could change the MAXNUMONOFF in the code (in include/makeinf.h) without issue. But the issue is that it really doesn't do much (if anything) for actual processing. The only use I've ever made of it (and that was rare) was with the window program which shows what your Fourier response function would look like given a window function based on the ONOFF pairs. But that isn't even used for anything except display purposes. So I'l probably just recommend not using ONOFF pairs at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants