Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][ENH] Fix coverage for multiprocessed functions #927

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arnaudbore
Copy link
Contributor

Quick description

Codecov is not covering multiprocessing functions.
https://app.codecov.io/gh/scilus/scilpy/blob/master/scilpy%2Freconst%2Fdivide.py#L266
...

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.17%. Comparing base (4c2848c) to head (de0060a).
Report is 124 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #927   +/-   ##
=======================================
  Coverage   69.17%   69.17%           
=======================================
  Files         389      389           
  Lines       20963    20963           
  Branches     3233     3233           
=======================================
  Hits        14501    14501           
  Misses       5132     5132           
  Partials     1330     1330           
Components Coverage Δ
Scripts 71.60% <ø> (ø)
Library 65.05% <ø> (ø)

@arnaudbore arnaudbore changed the title [ENH] Fix coverage for multiprocessed functions [WIP][ENH] Fix coverage for multiprocessed functions Mar 5, 2024
@arnaudbore arnaudbore added the WIP Work In Progress label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work In Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant