New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Module] ihMT module #70
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
NB: Are we going to make a module for “classic” MT images? I know there are people at Max who don't use ihMT, but could MT be a “myelin” sub-workflow?
It would be easy to almost copy paste this ihmt module and do a "mt" module. I plan to do it someday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two things, then this should be ready :
- Update your container to 2.0.2
- the
comp_maps
output in your tests is always empty. Is it normal ?
Good point, there was an option missing in the scil script command line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Describe your changes
I added a module for ihMT. Could not test it since I am waiting for scilpy 2.0. @Manonedde
Say which test data are used by your module
It uses ihMT.zip.
Checklist before requesting a review
./modules/nf-scil/<category>/<tool>/main.nf
./modules/nf-scil/<category>/<tool>/meta.yml
./tests/modules/nf-scil/<category>/<tool>/main.nf
./tests/modules/nf-scil/<category>/<tool>/nextflow.config