New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Module] Freesurfer reconall #66
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmaRenauld
force-pushed
the
module_reconall
branch
from
February 8, 2024 20:05
d07e50d
to
fdc05b8
Compare
EmmaRenauld
force-pushed
the
module_reconall
branch
from
May 16, 2024 17:16
fdc05b8
to
ffde5f1
Compare
EmmaRenauld
force-pushed
the
module_reconall
branch
from
May 16, 2024 19:33
ffde5f1
to
9bb17a0
Compare
arnaudbore
reviewed
May 17, 2024
Co-authored-by: Arnaud Bore <arnaud.bore@gmail.com>
EmmaRenauld
changed the title
[Module][WIP] Freesurfer reconall
[Module] Freesurfer reconall
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
New module reconall
New (fake) module reconalldebug
Issue 1) We wanted to skip the whole reconall test: way too long. Nf does not allow an empty test. Must at least create the version output. Thus created a debug module that is called instead, that only verifies that recon-all is found.
Issue 2) Requires the license file. Added as optional input. Ideally, user will have already set their environment correctly and does not need to send the license input. For the test data, added a license in our .test_data. For now, it is only in this PR, so I changed the base path TEMPORARILY so that the file is found. TO BE CHANGED BACK TO THE MASTER BRANCH BEFORE MERGING!
Tested locally (I let it run it only for a few minutes, but seems to work).
Say which test data are used by your module
Anat file + license.
Checklist before requesting a review
./modules/nf-scil/<category>/<tool>/main.nf
./modules/nf-scil/<category>/<tool>/meta.yml
./tests/modules/nf-scil/<category>/<tool>/main.nf
./tests/modules/nf-scil/<category>/<tool>/nextflow.config