Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Module] Freesurfer reconall #66

Merged
merged 19 commits into from May 21, 2024
Merged

Conversation

EmmaRenauld
Copy link
Contributor

@EmmaRenauld EmmaRenauld commented Feb 8, 2024

Describe your changes

New module reconall
New (fake) module reconalldebug

Issue 1) We wanted to skip the whole reconall test: way too long. Nf does not allow an empty test. Must at least create the version output. Thus created a debug module that is called instead, that only verifies that recon-all is found.

Issue 2) Requires the license file. Added as optional input. Ideally, user will have already set their environment correctly and does not need to send the license input. For the test data, added a license in our .test_data. For now, it is only in this PR, so I changed the base path TEMPORARILY so that the file is found. TO BE CHANGED BACK TO THE MASTER BRANCH BEFORE MERGING!

Tested locally (I let it run it only for a few minutes, but seems to work).

Say which test data are used by your module

Anat file + license.

Checklist before requesting a review

  • Create the tool:
    • Edit ./modules/nf-scil/<category>/<tool>/main.nf
    • Edit ./modules/nf-scil/<category>/<tool>/meta.yml
  • Generate the tests:
    • Edit ./tests/modules/nf-scil/<category>/<tool>/main.nf
    • Edit ./tests/modules/nf-scil/<category>/<tool>/nextflow.config
    • Add test data locally for tests with the fork repository
    • Generate the test infrastructure and md5sum for all outputs
  • Ensure the syntax is correct :
    • Check indentation abides with the rest of the library (don't hesitate to correct others !)
    • Lint everything. Ensure your variables have good names.

@AlexVCaron AlexVCaron changed the title Module reconall [Module][WIP] Freesurfer reconall Mar 8, 2024
@EmmaRenauld EmmaRenauld changed the title [Module][WIP] Freesurfer reconall [Module] Freesurfer reconall May 21, 2024
@arnaudbore arnaudbore merged commit 8eb34b1 into scilus:main May 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants